Skip to content

Fix broken link in user guide#772

Merged
pradyunsg merged 1 commit intopypa:masterfrom
wimglenn:patch-1
Sep 24, 2020
Merged

Fix broken link in user guide#772
pradyunsg merged 1 commit intopypa:masterfrom
wimglenn:patch-1

Conversation

@wimglenn
Copy link
Copy Markdown
Contributor

@wimglenn wimglenn commented Sep 22, 2020

Note: I actually don't know what pylauncher is, so if Vinay's project is not the right one then apologies
The setuptools docs also have the same broken link here https://setuptools.readthedocs.io/en/latest/easy_install.html#natural-script-launcher

I actually don't know what pylauncher is, just chose a likely suspect.


.. _pylauncher support: https://bitbucket.org/pypa/pylauncher
.. _pylauncher support: https://bitbucket.org/vinay.sajip/pylauncher
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wimglenn I think it's already in the stdlib. And the Python Docs website is integrated into this project via intersphinx.
So I guess you should just drop this line and use :ref:`python:launcher` as a reference right in the table instead.

@vsajip ^

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylauncher is a different project than the launcher that's in the core python distribution.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, pylauncher was the reference implementation for PEP-397 and that implementation was moved to become part of the Python distribution, with minor changes. Since the launcher now ships with Python, the pylauncher repository is really only of historical interest / perhaps worth looking at if there are regressions in the in-Python launcher. I do occasionally look at how much the in-Python version has diverged from pylauncher and have sometimes synced up changes, but it's not a priority or anything.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic of this particular page, "pip vs easy install", may also be primarily historical interest - so perhaps the reference implementation is actually the best place for the link target after all?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the page, I think it's all obsolete. I don't even know what "pylauncher support" means in this context. Certainly not as something pip doesn't have...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this pages needs updating! :)

Copy link
Copy Markdown
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in, as it's fixing a broken link, and we'll come back to the rest of this page afterwards. :)

@pradyunsg pradyunsg merged commit 9a207e9 into pypa:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants