Skip to content

Fix broken link in user guide #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradyunsg merged 1 commit into from
Sep 24, 2020
Merged

Fix broken link in user guide #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/discussions/pip-vs-easy-install.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ Here's a breakdown of the important differences between pip and easy_install now
.. [1] https://setuptools.readthedocs.io/en/latest/easy_install.html#natural-script-launcher


.. _pylauncher support: https://bitbucket.org/pypa/pylauncher
.. _pylauncher support: https://bitbucket.org/vinay.sajip/pylauncher
Copy link
Copy Markdown
Member

@webknjaz webknjaz Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wimglenn I think it's already in the stdlib. And the Python Docs website is integrated into this project via intersphinx.
So I guess you should just drop this line and use :ref:`python:launcher` as a reference right in the table instead.

@vsajip ^

Copy link
Copy Markdown
Member

@pfmoore pfmoore Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylauncher is a different project than the launcher that's in the core python distribution.

Copy link
Copy Markdown
Contributor

@vsajip vsajip Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, pylauncher was the reference implementation for PEP-397 and that implementation was moved to become part of the Python distribution, with minor changes. Since the launcher now ships with Python, the pylauncher repository is really only of historical interest / perhaps worth looking at if there are regressions in the in-Python launcher. I do occasionally look at how much the in-Python version has diverged from pylauncher and have sometimes synced up changes, but it's not a priority or anything.

Copy link
Copy Markdown
Contributor Author

@wimglenn wimglenn Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The topic of this particular page, "pip vs easy install", may also be primarily historical interest - so perhaps the reference implementation is actually the best place for the link target after all?

Copy link
Copy Markdown
Member

@pfmoore pfmoore Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the page, I think it's all obsolete. I don't even know what "pylauncher support" means in this context. Certainly not as something pip doesn't have...

Copy link
Copy Markdown
Member

@pradyunsg pradyunsg Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this pages needs updating! :)