fixtures: fix incorrect "duplicate parametrization" when using indirect=[...]
#13976
+121
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I tested this with the downstream test suite which lead to #13974 and with this PR the tests are back to passing. Thanks for the quick fix! |
The function name is ambiguous, full nodeid is more helpful.
Needed for the next commit.
…ect=[...]` The code in `_get_direct_parametrize_args` only handled `indirect=True/False`, it didn't account for `indirect=[...]`. This caused the added test to start failing after d56b1af. Fix by using the common `_resolve_args_directness` function. It's a bit heavy for the task but correctness first... Fix pytest-dev#13974.
bluetech
force-pushed
the
duplicate-parametrization-fix
branch
from
48d3478 to
adcdeb9
Compare
RonnyPfannschmidt
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in
_get_direct_parametrize_argsonly handledindirect=True/False, it didn't account forindirect=[...]. This caused the added test to start failing after d56b1af.Fix by using the common
_resolve_args_directnessfunction. It's a bit heavy for the task but correctness first...Fix #13974.
I am not marking for backport because the bug was laying dormant for a while and only uncovered by d56b1af which is only in main, not yet released.