feat: add --report-chars long option and its corresponding test #14024
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
jakkdl
reviewed
Dec 2, 2025
testing/test_config.py
Outdated
Comment on lines
100
to
106
| def test_report_chars_long_option( | ||
| self, pytester: Pytester, tmp_path: Path, monkeypatch: MonkeyPatch | ||
| ) -> None: | ||
| """Test that --report-chars is parsed correctly.""" | ||
| monkeypatch.setenv("PYTEST_ADDOPTS", "--report-chars=fE") | ||
| config = pytester.parseconfig(tmp_path) | ||
| assert config.option.reportchars == "fE" |
Member
There was a problem hiding this comment.
there's no suitable test for -r that can be parametrized? If not we could at least parametrize this one to test both the short and long version
…g forms with various values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14023
This change introduces a long-form CLI option
--report-charsas an alternative to the existingshort
-roption.Here is a quick checklist that should be present in PRs.
If this change fixes an issue, please:
closes #XYZWto the PR description and/or commits (whereXYZWis the issue number). See the github docs for more information.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
Create a new changelog file in the
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.Write sentences in the past or present tense, examples:
Also make sure to end the sentence with a
..Add yourself to
AUTHORSin alphabetical order.