Fix --help with required options #2458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by adding an argparse Action that will raise an exception in order to skip the rest of the argument parsing. This prevents argparse from quitting due to missing required arguments, similar to the way that the builtin argparse --help option is implemented by raising SystemExit. Fixes: pytest-dev#1999
|
Changes Unknown when pulling f74f14f on segevfiner:fix-required-options-help into ** on pytest-dev:master**. |
nicoddemus
approved these changes
Jun 1, 2017
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot for tackling this! 👍
|
|
||
|
|
||
| class HelpAction(Action): | ||
| def __init__(self, |
Member
There was a problem hiding this comment.
Could you add a short docstring here explaining this action? I guess basically what you wrote on the PR description would be great.
nicoddemus
reviewed
Jun 1, 2017
|
|
||
|
|
||
| class HelpAction(Action): | ||
| """This is an argparse Action that will raise an exception in |
|
Changes Unknown when pulling 9abff7f on segevfiner:fix-required-options-help into ** on pytest-dev:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by adding an argparse Action that will raise an exception in
order to skip the rest of the argument parsing. This prevents argparse
from quitting due to missing required arguments, similar to the way that
the builtin argparse --help option is implemented by raising SystemExit.
Fixes: #1999
P.S. I failed to run the tests on Python 3.6 due to pytest-dev/py#103
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
$issue_id.$typefor example (588.bug)removal,feature,bugfix,vendor,docortrivialbugfix,vendor,docortrivialfixes, targetmaster; for removals or features targetfeatures;Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS;