Make test parametrization override indirect fixtures#3629
Make test parametrization override indirect fixtures#3629nicoddemus merged 5 commits intopytest-dev:featuresfrom
Conversation
We don't deploy anything on tags with AppVeyor, we use Travis instead, so we might as well save resources
Skip AppVeyor builds on tag pushes
src/_pytest/fixtures.py
Outdated
| working_set.update(self.name2fixturedefs[argname][-1].argnames) | ||
|
|
||
| self.names_closure[:] = sorted( | ||
| closure, key=lambda name: self.names_closure.index(name) |
There was a problem hiding this comment.
the key could just be self.names_closure.index
|
since this one corrects a rather strange misbehavior, i wonder if its better to target the feature branch just to avoid certain kinds of disruption in a patch release CC @nicoddemus |
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
nice addition, do the type definitions do any good wrt tooling?
i believe this is good to go after we decide the target branch/disruption and add a changelog entry
|
@RonnyPfannschmidt I added those type definitions as a form of documentation, just to make it clear what the fields of FuncFixtureInfo are. Not sure what you mean by tooling. |
I haven't had a chance to review the PR yet, but I agree that even if this changes a somewhat wrong behavior, we better be safe and add this to the next feature release. |
|
@egnartsms aka mypy or something like that (because if its only acting as comments i consider it a liability) |
|
we will have to do our own homework first and merge master to features before this one can apply as intended |
|
#3634 will sort the conflict out then i will try again, |
|
@egnartsms oh, i missed it before, can you please add a news fragment about the bugfix once thats complete its good to merge 👍 |
|
@RonnyPfannschmidt do you mean to create a file in the changelog directory? Or something else? That's my first contribution to pytest. |
|
@edisongustavo correct a file in the changelog directory |
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Excellent work @egnartsms, thanks a lot!
4 participants
A fix for #2220.