-W now takes precedence over filters in ini files

[nicoddemus]

Fix #3946

cc @charris

[coveralls]

Coverage increased (+0.02%) to 93.905% when pulling ab40696 on nicoddemus:warnings-filter-precedence into d12f46c on pytest-dev:features.

[blueyed]

Coverage appears to be broken in features? https://ci.appveyor.com/project/pytestbot/pytest/build/1.0.5140/job/g4rvb1s3n5vpsb8v

call scripts\prepare-coverage.bat
'scripts\prepare-coverage.bat' is not recognized as an internal or external command,
operable program or batch file.

But scripts\prepare-coverage.bat appears to be in origin/features for me?!

[blueyed]

Ah, it was created before #3949 was merged.

@nicoddemus
I am going ahead and rebase it (old HEAD: cb2f525).

[codecov]

Codecov Report

Merging #3947 into features will decrease coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           features   #3947      +/-   ##
===========================================
- Coverage     94.48%   94.4%   -0.09%     
===========================================
  Files           107     107              
  Lines         23651   23665      +14     
  Branches       2349    2350       +1     
===========================================
- Hits          22347   22341       -6     
- Misses          993    1011      +18     
- Partials        311     313       +2

Flag	Coverage Δ
#doctesting	28.51% <11.76%> (+0.04%)	⬆️
#linux	94.4% <100%> (+0.04%)	⬆️
#nobyte	0% <0%> (ø)	⬆️
#numpy	28.14% <11.76%> (-0.01%)	⬇️
#pexpect	0% <0%> (ø)	⬆️
#pluggymaster	93.55% <100%> (-0.06%)	⬇️
#py27	92.54% <100%> (-0.06%)	⬇️
#py34	92.08% <100%> (-0.07%)	⬇️
#py35	92.09% <100%> (-0.07%)	⬇️
#py36	92.62% <100%> (-0.11%)	⬇️
#py37	92.25% <100%> (-0.11%)	⬇️
#trial	31.04% <23.52%> (-0.18%)	⬇️
#windows	?
#xdist	17.97% <11.76%> (-0.49%)	⬇️

Impacted Files	Coverage Δ
src/_pytest/warnings.py	88.6% <100%> (ø)	⬆️
testing/test_warnings.py	98.47% <100%> (+0.16%)	⬆️
testing/test_tmpdir.py	95.06% <0%> (-4.94%)	⬇️
src/_pytest/capture.py	86.72% <0%> (-3.21%)	⬇️
src/_pytest/nodes.py	93.69% <0%> (-0.85%)	⬇️
testing/acceptance_test.py	97.14% <0%> (-0.66%)	⬇️
src/_pytest/pytester.py	85.56% <0%> (-0.46%)	⬇️
testing/test_capture.py	98.94% <0%> (-0.31%)	⬇️
src/_pytest/fixtures.py	96.99% <0%> (-0.28%)	⬇️
testing/python/metafunc.py	95.06% <0%> (ø)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12f46c...ab40696. Read the comment docs.

[nicoddemus]

Thanks @blueyed for picking this up!