Fix typing of params ids callable form #7496
Merged
bluetech merged 2 commits intopytest-dev:masterfrom Jul 15, 2020
Merged
Conversation
We probably something a bit more elaborate in the future but for now it's something to verify fixes and catch regressions.
The previous typing had an object passed to the user, which they can't do anything with without asserting, which is inconvenient. Change it to Any instead. Note that what comes *back* to pytest (the return value) should be an `object`, because we want to handle arbitrary objects without assuming anything about them.
4 tasks
1 task
nicoddemus
reviewed
Jul 14, 2020
| @@ -0,0 +1,24 @@ | |||
| """File for checking typing issues. | |||
nicoddemus
approved these changes
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7494.
There is also a commit which adds a
testing/typing_check.pyfile whose purpose is only to not have any mypy errors.