Skip to content

Comments

Configure setuptools_scm using pyproject.toml#7598

Merged
asottile merged 4 commits intopytest-dev:masterfrom
nicoddemus:setuptools-scm-pyproject
Aug 2, 2020
Merged

Configure setuptools_scm using pyproject.toml#7598
asottile merged 4 commits intopytest-dev:masterfrom
nicoddemus:setuptools-scm-pyproject

Conversation

@nicoddemus
Copy link
Member

@RonnyPfannschmidt locally this doesn't seem to work, pip list says pytest 0.0.0 is installed after running pip install -e .. Any hints?

@RonnyPfannschmidt
Copy link
Member

You might need to update setuptools as well, the feature go added quit recent

@nicoddemus
Copy link
Member Author

Thanks, you probably mean 42.0:

#1877: Setuptools now exposes a new entry point hook "setuptools.finalize_distribution_options", enabling plugins like setuptools_scm to configure options on the distribution at finalization time.

@nicoddemus
Copy link
Member Author

Still no go (and probably wasn't the error before anyway because CI was installing the last version anyway), any idea of what might be missing?

@asottile
Copy link
Member

asottile commented Aug 1, 2020

sighhhh rtd invokes setup.py install

@nicoddemus
Copy link
Member Author

Thanks @asottile!

Added a .readthedocs.yml to use pip for installation, let's see...

@nicoddemus
Copy link
Member Author

Woot!

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 701998b into pytest-dev:master Aug 2, 2020
@nicoddemus nicoddemus deleted the setuptools-scm-pyproject branch August 2, 2020 13:44
@nicoddemus
Copy link
Member Author

Thanks @asottile!

No big deal, but probably better to have squashed & merged this. 👍

@asottile
Copy link
Member

asottile commented Aug 2, 2020

ah shoot, oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants