Skip to content

Comments

py36+: remove _pytest.compat.order_preserving_dict#7863

Merged
asottile merged 1 commit intopytest-dev:masterfrom
asottile:py36_order_preserving_dict
Oct 6, 2020
Merged

py36+: remove _pytest.compat.order_preserving_dict#7863
asottile merged 1 commit intopytest-dev:masterfrom
asottile:py36_order_preserving_dict

Conversation

@asottile
Copy link
Member

@asottile asottile commented Oct 6, 2020

See #7808

@bluetech
Copy link
Member

bluetech commented Oct 6, 2020

I thought it was only since 3.7?

@asottile
Copy link
Member Author

asottile commented Oct 6, 2020

I thought it was only since 3.7?

implemented and provisional in cpython 3.6 (pypy since 3.5), and permanently specified in 3.7

Copy link
Member

@bluetech bluetech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh so that should cover it.

@nicoddemus
Copy link
Member

Huh so that should cover it.

Yep, seems like it, PyPy has that since 2015 so it should be covered there as well (in fact CPython borrowed the implementation IIRC).

@asottile asottile merged commit 95917f8 into pytest-dev:master Oct 6, 2020
@asottile asottile deleted the py36_order_preserving_dict branch October 6, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants