deprecated_call does not revert warning functions back to original v2#803
Merged
nicoddemus merged 3 commits intopytest-dev:pytest-2.7from Jun 26, 2015
pieterproigia:pytest-2.7
Merged
deprecated_call does not revert warning functions back to original v2#803nicoddemus merged 3 commits intopytest-dev:pytest-2.7from pieterproigia:pytest-2.7
nicoddemus merged 3 commits intopytest-dev:pytest-2.7from
pieterproigia:pytest-2.7
Conversation
Make sure that the warnings.warn and warnings.warn_explicit are reverted to there original function after running the function in deprecated_call
Test if we preserve the correct functions.
Member
There was a problem hiding this comment.
Could you add a "Thanks Pieter Mulder for PR." to the end, as we usually do with the other entries. Thanks
Member
|
After my small note about the changelog entry, looks 👍 to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #802 Rebased on branch pytest-2.7
Added test and data in AUTHORS and CHANGELOG