EpsFilePlugin Speed improvements. #886
Conversation
Read the rest of the text data using one of the line ending wrappers.
|
Changes Unknown when pulling 918c77e on wiredfool:epsfile-rebase into * on python-pillow:master*. |
|
2 notes. I've disabled some tests that weren't testing our code. They do pass where expected, and fail in a portion that's an edge case in the spec. Those tests indicate that the way that we're treating the line endings isn't 100% to spec if we use the builtin python universal line endings file wrappers. We can do it correctly, but slower, by only using our internal python file pointer wrapper PSFile. This should only be an issue if an eps file mixes line endings in one file or uses the really messed up \n\r combination. |
|
Changes Unknown when pulling ce0fcef on wiredfool:epsfile-rebase into * on python-pillow:master*. |
EpsFilePlugin Speed improvements.
|
Since we're reading only comments and an empty line simply does not count as a comment, as would be the case with \n\r, I'm still in favor of using universal+'ignore empty lines'. Let's not forget that GS does the work even though source comments indicate otherwise. All we need to do is read as much meta data as we can get from the ps/eps. |
Fix for #838.
@karstenw -- Sorry on the delay for this. This should be what we've discussed in #838, stripped down to remove excess code in a few places.