If TGA v2 extension area specifies no alpha, fill alpha channel#9478
Open
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Open
If TGA v2 extension area specifies no alpha, fill alpha channel#9478radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9473
Using https://www.fileformat.info/format/tga/egff.htm as a reference, I found that v2 TGA files may has a 26 byte footer at the end of the file. The first 4 bytes point to the 'extension area', the last byte of which is 'AttributesType'. If this is zero, then the file should not has any alpha.
To avoid seeking to the end of the file during
open), I'm only checking this value inload_end(), and filling the alpha channel at that point.