You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#9395 changed the C setimage() so extents needed to be passed in. However, I've realised that both before and after that, the C setimage() never accepted None.
For background, #1938 added the Python setimage(), which accepted None for the extents, and tested for it accordingly. #8285 added None as a possible value to the extents type hint in a tile.
I think we should aim for the same behaviour with the C and Python setimage(). It is fair enough to say that removing None as a possible extents value for Python setimage() is a breaking change, so I'm now going in the opposite direction with this PR - allowing None as an extents value in the C setimage().
radarhere
changed the title
Simplify setimage()
Allow None extents in C setimage()
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #9395