Use plugin method directly when saving PDFs#9547
Open
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Open
Use plugin method directly when saving PDFs#9547radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9545
currently raises
The problem is that at line 151 (and for mode RGBA at line 154) JpegImagePlugin (and Jpeg2KImagePlugin) haven't necessarily been imported.
Pillow/src/PIL/PdfImagePlugin.py
Lines 150 to 154 in c722aae
One solution would be to import the plugins, so that
register_save()is called, and still useImage.SAVE. However, lint raises an error that the imported plugins are not used.I think it is better to actually call the plugin method directly, like MpoImagePlugin does.