Skip to content

Extract with assignment issue 376#391

Merged
lieryan merged 9 commits into
python-rope:masterfrom
climbus:extract_with_assignment
Sep 18, 2021
Merged

Extract with assignment issue 376#391
lieryan merged 9 commits into
python-rope:masterfrom
climbus:extract_with_assignment

Conversation

@climbus

@climbus climbus commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

Fix #376

Fix bug with replacing right side of assignment. I don't know ast well. If you know any cases which may not work, please send me an example.

@lieryan lieryan added this to the 0.21.x milestone Sep 18, 2021

@lieryan lieryan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lieryan lieryan merged commit f46c113 into python-rope:master Sep 18, 2021
lieryan added a commit that referenced this pull request Sep 18, 2021
Very similar to the case resolved in #391 by @climbus, but for index
assignment instead of attribute assignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extract method only with instance variable change assigment

2 participants