Global declaration in extracted method

[climbus]

316

Added support for global expression.

• test task list checker

[climbus]

@lieryan Can you tell me why task is failing? Thanks

[lieryan]

It shouldn't fail. That's a new Github Actions I added recently to enforce that all task list must be checked before merging. Your PR doesn't contain any task list, so it should not have failed; it seemed to be failing because of an unrelated issue because the task list don't have permission to access your fork or something like that.

I'll try and see if there's other different task list plugins that doesn't fail in such situations.

[climbus]

Same here #391

[lieryan]

Hi @climbus, I made some changes to Github Actions that should hopefully resolve the task-completed-checker issue. Can you check if this issue is still there after you pull the latest master into this branch?

[climbus]

! [remote rejected] global_declaration -> global_declaration (refusing to allow a Personal Access Token to create or update workflow .github/workflows/task-completed-checker-action.yml without workflow scope)

[lieryan]

Hi thanks for trying that out. Can you try rebasing this branch on top of the latest master and then using force push, something like this:

$ git fetch
$ git rebase origin/master global_declaration --onto origin/master
# ... resolve any rebase conflicts ...
$ git push --force

[climbus]

Unfortunately still errors
! [remote rejected] global_declaration -> global_declaration (refusing to allow a Personal Access Token to create or update workflow .github/workflows/task-completed-checker-action.yml without workflow scope)

! [remote rejected] master -> master (refusing to allow a Personal Access Token to create or update workflow .github/workflows/task-completed-checker-action.yml without workflow scope)

[lieryan]

Can you try if making a new pull request from the rebased branch works?

[lieryan]

Would doing self.globals_.add(*node.names) like the other _Global work here as well?

[climbus]

Can you try if making a new pull request from the rebased branch works?

After rebase I can't push any commit in any branch on my fork. When I remove task check file, I can push again.

[climbus]

Can you try if making a new pull request from the rebased branch works?

After rebase I can't push any commit in any branch on my fork. When I remove task check file, I can push again.

Ok forget it. I had wrong permissions on token. Now it works fine. Thanks for help.

[lieryan]

Hi @climbus, great work on this one as usual 💯