Skip to content

construct empty exceptions with no arguments, instead of () and {}#365

Merged
bbangert merged 2 commits intopython-zk:masterfrom
radix:construct-exceptions-with-saner-arguments
May 31, 2017
Merged

construct empty exceptions with no arguments, instead of () and {}#365
bbangert merged 2 commits intopython-zk:masterfrom
radix:construct-exceptions-with-saner-arguments

Conversation

@radix
Copy link
Copy Markdown
Contributor

@radix radix commented Nov 13, 2015

Here's a simple change to get rid of the weird exceptions with () and {} passed as arguments.

No tests failed by this change, so I guess it's reasonably backwards-compatible; I did add a simple test for the new behavior.

This partially addresses #362.

@radix
Copy link
Copy Markdown
Contributor Author

radix commented Nov 13, 2015

AFAICT the failures in travis are unrelated to my change, but I'm not completely sure of that.

@radix
Copy link
Copy Markdown
Contributor Author

radix commented Nov 18, 2015

Ping. I don't think I have access to retry the travis tests... but I've run the builds that failed locally and they passed, so I don't think there's a problem with the branch... could an admin retry the build?

@harlowja
Copy link
Copy Markdown
Contributor

I'll get that retried (since I have the power),

Btw feel free to jump on #zookeeper irc channel on freenode if u need more
immediate response.

On Wednesday, November 18, 2015, Christopher Armstrong <
notifications@github.com> wrote:

Ping. I don't think I have access to retry the travis tests... but I've
run the builds that failed locally and they passed, so I don't think
there's a problem with the branch... could an admin retry the build?


Reply to this email directly or view it on GitHub
#365 (comment).

facebook.com/jshharlow http://www.facebook.com/jshharlow
flickr.com/jshharlow
YIM: jshharlow

@harlowja
Copy link
Copy Markdown
Contributor

harlowja commented Dec 8, 2015

👍 seems ok to me.

@bbangert bbangert merged commit 5c4e006 into python-zk:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants