bpo-3041: fix running subprocess.run() with shell=True and args being a list - #1083
Closed
dmerejkowsky wants to merge 1 commit into
Closed
bpo-3041: fix running subprocess.run() with shell=True and args being a list#1083dmerejkowsky wants to merge 1 commit into
dmerejkowsky wants to merge 1 commit into
Conversation
|
@dmerejkowsky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gpshead, @tim-one and @rosslagerwall to be potential reviewers. |
Author
|
Hum. Test are failing. Looks like the fix is less obvious than I thought. To be continued ... |
Author
|
As seen on bugs.python.org, this is not a bug. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure yet if it's the best way to go.
If so, I'll need guidance to path the tests too