Skip to content

bpo-3041: fix running subprocess.run() with shell=True and args being a list #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmerejkowsky wants to merge 1 commit into from
Closed

bpo-3041: fix running subprocess.run() with shell=True and args being a list #1083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import io
import os
import time
import shlex
import signal
import builtins
import warnings
Expand Down Expand Up @@ -1209,7 +1210,8 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
# On Android the default shell is at '/system/bin/sh'.
unix_shell = ('/system/bin/sh' if
hasattr(sys, 'getandroidapilevel') else '/bin/sh')
args = [unix_shell, "-c"] + args
cmdline = " ".join(shlex.quote(x) for x in args)
args = [unix_shell, "-c", cmdline]
if executable:
args[0] = executable

Expand Down