Closed
Conversation
Fixed drop-down menu. The description can be found here. #1124
ghost
changed the title
ghost
changed the title
berkerpeksag
requested changes
Nov 21, 2017
Member
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
Thank you for the PR. mq.css is an automatically generated file. Please modify static/sass/mq.scss instead.
berkerpeksag
requested changes
Nov 21, 2017
|
|
||
| .element-4 ul, | ||
| .element-2 ul{ | ||
| height:288px; |
Member
There was a problem hiding this comment.
We don't use px as unit. Please use the px2em helper.
Also, is there a way to fix this without set <ul>'s height to a fixed value?
| width: device-width; } | ||
|
|
||
|
|
||
| .element-4 ul, |
Member
There was a problem hiding this comment.
We support multiple devices so this should be moved into one of the applicable media blocks like
@media (min-width: px2em( ... )) {
}
Author
|
I have made changes and made a pull request, but it has gone to the new pull request. |
Member
|
Superseded by #1209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed drop-down menu. The description can be found here.
issue #1124