Skip to content

Fixed issue #1124 #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Fixed issue #1124 #1183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions static/sass/mq.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2528,3 +2528,11 @@ html[xmlns] .slides { display: block; }

@viewport {
width: device-width; }


.element-4 ul,
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support multiple devices so this should be moved into one of the applicable media blocks like

@media (min-width: px2em( ... )) {

}

.element-2 ul{
height:288px;
Copy link
Copy Markdown
Member

@berkerpeksag berkerpeksag Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use px as unit. Please use the px2em helper.

Also, is there a way to fix this without set <ul>'s height to a fixed value?

overflow:hidden;
overflow-y:scroll;
}