Skip to content

[ExecuTorch][WebGPU] Add HuggingFace rotate-half RoPE#21135

Open
JCNTH wants to merge 4 commits into
gh/JCNTH/111/basefrom
gh/JCNTH/111/head
Open

[ExecuTorch][WebGPU] Add HuggingFace rotate-half RoPE#21135
JCNTH wants to merge 4 commits into
gh/JCNTH/111/basefrom
gh/JCNTH/111/head

Conversation

@JCNTH

@JCNTH JCNTH commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

Qwen models use the HuggingFace rotate-half rotary embedding, which pairs the
first and second halves of each head vector rather than adjacent elements as the
existing interleaved Llama RoPE does. This adds the rotate-half operator with
dynamic start-position updates, full-dimension Q/K head handling, a generated
WGSL kernel, and a strict frequency-table bound that rejects out-of-range
positions; the interleaved Llama route is left unchanged. Mirrors Vulkan
xplat/executorch/backends/vulkan/runtime/graph/ops/glsl/rotary_embedding_hf.glsl.

Key changes:

  • runtime/ops/rope/rotary_embedding_hf.wgsl (+ generated header): one-thread-
    per-pair rotate-half rotation reading the first-half frequency column.
  • RotaryEmbedding.cpp: HF-variant lowering, dynamic start_pos, and the
    frequency-table bound check.
    @exported-using-ghexport

Differential Revision: D113171746

Differential Revision: D113171746

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21135

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Unrelated Failure

As of commit 0c45a43 with merge base 86c3470 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2026
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants