Filtering search results by two words (in any order)

[joshhoughton]

Currently once a search has completed in the Search tab, you're able to filter results where an input phrase is checked to see if it exists in a result name.

Often I find myself wanting to filter by two different words, foo and bar. When filtering by just foo bar, only results that contain foo and bar straight after each other are returned. I've taken a look at the underlying code and it looks like this should work just fine.

Once the inputted filter string is changed, it's split on (spaces) (if greater than 2 characters in length and not wrapped in "'s), so I presume that the m_searchTermWords array would look something like {"foo", "bar"}.

qBittorrent/src/gui/search/searchsortmodel.cpp

Lines 52 to 59 in 8df80b6

	void SearchSortModel::setNameFilter(const QString &searchTerm)
	{
	m_searchTerm = searchTerm;
	if ((searchTerm.length() > 2) && searchTerm.startsWith(u'"') && searchTerm.endsWith(u'"'))
	m_searchTermWords = QStringList(m_searchTerm.mid(1, m_searchTerm.length() - 2));
	else
	m_searchTermWords = searchTerm.split(u' ', Qt::SkipEmptyParts);
	}

Then the results are updated by checking that each phrase in m_searchTermWords exist inside each result's title.

qBittorrent/src/gui/search/searchsortmodel.cpp

Lines 130 to 138 in 8df80b6

	if (m_isNameFilterEnabled && !m_searchTerm.isEmpty())
	{
	const QString name = sourceModel->data(sourceModel->index(sourceRow, NAME, sourceParent), UnderlyingDataRole).toString();
	for (const QString &word : asConst(m_searchTermWords))
	{
	if (!name.contains(word, Qt::CaseInsensitive))
	return false;
	}
	}

Anyone got any ideas why foo bar won't return results that contain bar foo in practice?

[joshhoughton]

Opened an issue #18605