WebUI API: setShareLimits method returns status code 400

[antonkvm]

qBittorrent & operating system versions

qBittorrent: v4.6.2 (64-Bit)
Operating System: Raspberry Pi OS / Debian GNU/Linux 11 (bullseye)
Qt: 6.6.1
libtorrent: 2.0.9.0

What is the problem?

Trying to use the setShareLimits API method no longer works and currently returns "400 - Bad Request". I used the same request previously in a python script, which used to work as expected. I can verify that my last successful call to that API method was on November 11th 2023, but I can't pinpoint what version I was using back then, although I do update fairly regularly. I have not changed the way I call that method since.

I have tried out using other API methods, like /torrents/addTags, using the same torrent hash and session cookie, and that still succeeds as expected.

Steps to reproduce

1. Use the /auth/login method to fetch a session cookie
2. Use that session cookie to make a POST request to the /torrents/setShareLimits API endpoint (see below for details)
3. See that the HTTP response is code 400, bad request. Checking the share limits in the WebUI shows that the intended changes were not applied.

Additional context

cURL Snippet generated by Postman:

curl --location 'https://[redacted_host]/api/v2/torrents/setShareLimits' \
--header 'Content-Type: application/x-www-form-urlencoded' \
--header 'Cookie: SID=[redacted]' \
--data-urlencode 'hashes=[redacted]' \
--data-urlencode 'ratioLimit=13.0' \
--data-urlencode 'seedingTimeLimit=13000.0'

<< removed irrelevant logs and preferences >>

[PISTOLCUPCAKES]

I'm seeing the same issue on 4.6.2 using a script that previously worked (not sure which version it worked on). I also tried submitting the request with form data, as that was the fix for a different endpoint, but that didn't work either.
Postman request formatted with form-data:

curl --location --request POST 'http://[redacted]/api/v2/torrents/setShareLimits' --header 'Cookie: SID=[redacted]' --form 'hashes="[redacted]"' --form 'ratioLimit="-1"' --form 'seedingTimeLimit="14400"'

[antonkvm]

I figured out that the last version where this API method still worked was v4.5.5. So the issue must have been caused by something in the v4.6.0 release.

[glassez]

So the issue must have been caused by something in the v4.6.0 release.

#19294 has added one more parameter to setShareLimits request.

[antonkvm]

I see, thanks! Adding the inactiveSeedingTimeLimitparameter to the setShareLimits request solved my issue.

Here is my now working API request:

curl --location 'https://[redacted_host]/api/v2/torrents/setShareLimits' \
  --header 'Content-Type: application/x-www-form-urlencoded' \
  --header 'Cookie: SID=[redacted_session_cookie]' \
  --data-urlencode 'hashes=[redacted_torrent_info_hash]' \
  --data-urlencode 'ratioLimit=10' \
  --data-urlencode 'seedingTimeLimit=-1' \
  --data-urlencode 'inactiveSeedingTimeLimit=-1'

I appreciate your reply, but shouldn't this have been communicated in the release notes and the WebUI API reference? I was pretty stumped until now and was unable to find any resources pointing me to this solution. And in general, would it not be helpful to include a short error message in the API response, something like "Bad Request: missing parameter"?

I'll gladly contribute this info to the wiki myself, once I figure out how that works.