Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport changes to v4.6.x branch #19751

Merged
merged 24 commits into from
Nov 13, 2023
Merged

Backport changes to v4.6.x branch #19751

merged 24 commits into from
Nov 13, 2023

Commits on Nov 8, 2023

  1. Add I2P settings to WebUI 

    PR qbittorrent#19700.
    @thalieht @glassez
    thalieht authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    7b73d3f View commit details
    Browse the repository at this point in the history

  2. CI: Use dynamic MSVC run-time library 

    Otherwise, there is a conflict of run-time libraries used (since Qt DLLs are still use dynamic MSVCRT) that leads to strange errors.

PR qbittorrent#19718.
Closes qbittorrent#19701.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    dc31e82 View commit details
    Browse the repository at this point in the history

  3. Combine CSS properties 

    PR qbittorrent#19730.
    @Chocobo1 @glassez
    Chocobo1 authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4b56bdd View commit details
    Browse the repository at this point in the history

  4. Prevent crash due to race condition when adding magnet link 

    PR qbittorrent#19792.
Closes qbittorrent#19780.
Closes qbittorrent#19790.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    42d7465 View commit details
    Browse the repository at this point in the history

  5. Fix Enter key behavior when add new torrent 

    PR qbittorrent#19787.
Closes qbittorrent#19760.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a1317e2 View commit details
    Browse the repository at this point in the history

  6. WebUI: Fix duplicate scrollbar on Transfer List 

    The overlay scrollbars introduced in Firefox 100 take up no space,
breaking the existing overflow detection.
Add an extra check for `scrollHeight != clientHeight` which is able to
detect an overflow independent of scrollbar style.

PR qbittorrent#19779.

---------

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
    @AgentConDier @Chocobo1 @glassez
    2 people authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a396e0d View commit details
    Browse the repository at this point in the history

  7. Remove "Physical memory (RAM) usage limit" option on macOS qbittorren… 

    …t#19805

This has no effect on macOS.
https://stackoverflow.com/questions/3274385/how-to-limit-memory-of-a-os-x-program-ulimit-v-neither-m-are-working

Closes qbittorrent#18656.
PR  qbittorrent#19805.
    @Chocobo1 @glassez
    Chocobo1 authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bb6d69f View commit details
    Browse the repository at this point in the history

  8. GHA CI: don't override cmake default CXXFLAGS

    @Chocobo1 @glassez
    Chocobo1 authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    31e0ab2 View commit details
    Browse the repository at this point in the history

  9. Add missing main window icon 

    PR qbittorrent#19815.

---
Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @iomezk @glassez
    iomezk authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3c0747f View commit details
    Browse the repository at this point in the history

  10. Don't forget to delete TorrentContentAdaptor instance 

    PR qbittorrent#19825.
Closes qbittorrent#19816.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d5c0c09 View commit details
    Browse the repository at this point in the history

  11. Fix .torrent file upload on iPadOS 

    Mobile Safari on iOS does report `ios` platform, but iPadOS reports `mac`
instead. It is common sense to check for touch points when this happens
to differentiate Mac and iPad.

PR qbittorrent#19822.
Closes qbittorrent#19057.

---------

Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
    @vit9696 @glassez
    vit9696 and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ee853d8 View commit details
    Browse the repository at this point in the history

  12. Update size of selected files when selection is changed 

    PR qbittorrent#19827.
Closes qbittorrent#19818.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b284d40 View commit details
    Browse the repository at this point in the history

  13. Correctly handle changing save path of torrent w/o metadata 

    PR qbittorrent#19829.
Closes qbittorrent#19824.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a14b50e View commit details
    Browse the repository at this point in the history

  14. Allow to request torrents count via WebAPI 

    PR qbittorrent#19831.
Closes qbittorrent#19731.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    54dffa1 View commit details
    Browse the repository at this point in the history

  15. WebUI: Fix incorrect subcategory sorting 

    PR qbittorrent#19833.
Closes qbittorrent#19756.
    @Bartuzen @glassez
    Bartuzen authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    837d39d View commit details
    Browse the repository at this point in the history

  16. Always use QStyledItemDelegate as base of delegate classes 

    PR qbittorrent#19340.
    @glassez
    glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    903173b View commit details
    Browse the repository at this point in the history

  17. Use appropriate icon for "moving" torrents in transfer list 

    PR qbittorrent#19821.
    @xavier2k6 @glassez
    xavier2k6 authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c2dd53c View commit details
    Browse the repository at this point in the history

  18. Remove column span 

    The property widget already has scroll bars and thus we don't need this span.

Closes qbittorrent#15000.
PR qbittorrent#19404.
    @Chocobo1 @glassez
    Chocobo1 authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c7dfc1d View commit details
    Browse the repository at this point in the history

  19. WebUI: Remove extra ')' in QBT_TR macro 

    PR qbittorrent#19894.
    @itsnotv @glassez
    itsnotv authored and glassez committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    2c2252d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Drop WebUI default credentials 

    PR qbittorrent#19777.
    @glassez
    glassez committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    786c09e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. WebUI: Correctly set save path in RSS rules 

    PR qbittorrent#19916.
Closes qbittorrent#19915.
    @glassez
    glassez committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    3007762 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. WebUI: Minor optimizations to the login page

    @sledgehammer999 @glassez
    sledgehammer999 authored and glassez committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    43300d9 View commit details
    Browse the repository at this point in the history

  2. Improve performance of getting torrent numbers via WebAPI 

    PR qbittorrent#19919.
    @Chocobo1 @glassez
    Chocobo1 authored and glassez committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    59d968e View commit details
    Browse the repository at this point in the history

  3. Improve free disk space checking for WebAPI 

    Use single free disk space checker instance for all the web sessions.

PR qbittorrent#19855.
Closes qbittorrent#19732.
    @glassez
    glassez committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b824889 View commit details
    Browse the repository at this point in the history