-
Notifications
You must be signed in to change notification settings - Fork 37
Add driven controls #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
robertlove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTM
|
Few more changes. The module name is driven controls (this is fine because it contains multiple driven controls). However the class name should be DrivenControl (not DrivenContorls) furthermore the file containing DrivenControl should also be named DrivenControl. The names of the driven controls would be better if we use the common abbreviation, similar to BLACK OPAL. This is within our conventions as most of the DrivenContorl names are longer than three words. 'wimperis_1' => 'BB1' 'solovay_kitaev_1' => 'SK1' 'walsh_amplitude_modulated_filter_1' => 'WAMF1' 'compensating_for_off_resonance_with_a_pulse_sequence' => 'CORPSE' 'compensating_for_off_resonance_with_a_pulse_sequence_with_wimperis' => 'CORPSE in BB1' 'compensating_for_off_resonance_with_a_pulse_sequence_with_solovay_kitaev' => 'CORPSE in SK1' 'short_composite_rotation_for_undoing_length_over_and_under_shoot' => 'SCROFULOUS' 'corpse_in_scrofulous_pulse' => 'CORPSE in SCROFULOUS' Note in all cases the variable name should be the capitalized version of the same words. So for the last one it would be: CORPSE_IN_SCROFULOUS = 'CORPSE in SCROFULOUS' |
|
Hi Rajib, |
…ntrols into add_driven_controls
…ntrols into add_driven_controls
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method # This is the commit message #12: Public methods are bundled as __all__; changed ported over to notebooks; base object removed; repr method created # This is the commit message #13: additional error handling for new repr method # This is the commit message #14: repr method updated with class instance as input
Adding driven controls to the library. Includes several predefined driven controls + tests and an example notebook.