Migrate notebooks. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@stevegore the notebooks were previously automatically checked in the testing. They have been migrated, so could you please remove them from the circleCI automated tests. |
Contributor
rajibchakravorty
left a comment
rajibchakravorty
left a comment
There was a problem hiding this comment.
Because notebooks are removed from here,
- we do not need
nbvalas dependency here anymore (insetup.py(this was to run the notebooks automatically)
-we do not need- run: pytest --nbval-lax examples/*.ipynb --sanitize-with examples/notebook-sanitize.cfgline in .circleci/config.yml
Contributor
|
Hey all, the builds will automatically add I'm going to put some documentation on how to do this sort of thing, but for the moment:
curl -sSL https://raw.githubusercontent.com/sdispater/poetry/master/get-poetry.py | python
poetry remove --dev nbvalHappy to walk through with you guys in more detail via chat if you'd rather. |
Contributor
|
Actually, just realised your branch has the old workflow. I'll need to get my PR merged, then you can get merge in those chances into this PR, then the above applies. After I have the release done I'll ensure that happens. |
Contributor
|
@rajibchakravorty @michaelhush I've done this for you for this PR. Going to merge. Still having issues with it expecting a check that doesn't exist. |
michaelhush
pushed a commit
that referenced
this pull request
Jul 8, 2019
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method
michaelhush
pushed a commit
that referenced
this pull request
Jul 8, 2019
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method # This is the commit message #12: Public methods are bundled as __all__; changed ported over to notebooks; base object removed; repr method created # This is the commit message #13: additional error handling for new repr method # This is the commit message #14: repr method updated with class instance as input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebooks have been migrated to https://github.com/qctrl/notebooks/tree/master/qctrl-open-controls and readme has been updated accordingly.