Adding cirq support #5

rajibchakravorty · 2019-05-23T00:44:36Z

Major : Add method to convert a DDS to a cirq.Circuit or cirq.Schedule

Request for review:

circuit_type is an option with 2 possible string values - a) 'standard circuit' - where the circuit will contain sequence operations and gaps will be filled up by identity gates; returns a cirq.Circuit instance b) 'scheduled circuit' - where sequence operations are scheduled to be occurring at offsets and does not require any Identity gates to fill; returns a cirq.Schedule instance; in either case the returned instance is accepted by cirq.Simulator for simulation (both are illustrated in the notebook. Please check if the string keys make sense.
Example notebook in examples/run_a_dds_on_cirq.ipynb.

Other additions/points to consider:

Pre-Post gates are specified here as a . 2x2 unitary matrix. This can accommodate the default X_{pi/2} or other rotations too (similar to angle notation in U3 gate in Qiskit)
The drawing of circuit is not great in cirq. Especially the 2x2 matrix at both ends looks bad (see the example notebook). But I could not find a nicer way to draw the circuit. Same comment applies to result - no nice direct API to draw/beatify the outcome.
In the absence of an actual device, demonstration of noisy system was not possible [so removed the comparison with Ramsey sequence]. Alternative was to use artificial noise models. But the library provides limited noisy gates/channels and the knowledge of noise had to known a-priori. I would consider this as beyond scope of the notebook at this moment.

qctrlopencontrols/cirq/cirq_circuit.py

charmasaur · 2019-05-23T01:19:20Z

qctrlopencontrols/cirq/cirq_circuit.py

+        with a string as key. The string is formatted as 'qubit-X' where
+        X is a number between 0 and len(target_qubits).
+    circuit_type : str, optional
+        One of 'scheduled circuit' or 'standard circuit'. In the case of


I'm not really sure about python best practice here, but instead you could refer to constants.SCHEDULED_CIRCUIT and constants.STANDARD_CIRCUIT. That might make it a bit harder to pass an invalid value (even though we don't have a compiler, people might use IDEs that warn them about using non-existent constants).

I went with legacy here. If this needs to be changes, we have to check carefully other similar instances.

…iour

…ost-gate

michaelhush · 2019-05-24T07:02:11Z

Comments:

There is some inconsistency with the naming. Currently we use IBM Q and cirq in the same way which isn't quite right. I think we should change the example file, and accordingly title, for running_a_dds_on_ibm_q.ipynb to export_a_dds_to_qiskit.ipynb. This actually matches the description of the file in the readme, so that helps. This also means we should change cirq example to export_a_dds_to_cirq.ipynb.
Add a brief description of the Export a DDS to Cirq jupytet notebook to the README.

…d description for the cirq notebook

rajibchakravorty · 2019-05-24T07:21:04Z

Notebook names and titles changed
Add a couple of sentences on Cirq notebook in Readme.

michaelhush · 2019-05-24T07:31:56Z

Consistency comments:

With qiskit, we have a qiskit module then we have the method convert_dds_to_quantum_circuit which returns a QuantumCircuit object. The file is called quantum_circuit.py. I want to match this pattern as much as possible.

Cirq currently has a method convert_dds_to_cirq_circuit which returns two different types of objects, Circuits or Schedules. It also has the term cirq inserted. This breaks the pattern above.

To change the cirq module to match the qiskit module we should remove this "circuit_type" keyword altogether (and it's constants) and instead use two method:

convert_dds_to_circuit
convert_dds_to_schedule

Each method now returns a predictable type, which is clearer. They are implied to be for cirq through the module. Technically they should also be in separate files circuit.py and schedule.py to keep the pattern consistent. If there is any shared code I wouldn't mind it being in one of them and imported by the other. But just make sure there is not mutual importing errors.

…algorithm keyword removed from qiskit example

…me in text updated to 0.4 to match the code

…le in respective files

rajibchakravorty · 2019-05-27T02:48:10Z

updates:

Conversion to cirq circuit and schedule separated in two files (with common methods imported from qiskit module where needed
Notebooks updated accordingly. Minor change in qiskit notebook also (e.g. matching the gate_time in description and actual code and some tex format for micorseconds etc.).

michaelhush · 2019-05-30T01:47:22Z

qctrlopencontrols/cirq/circuit.py

+from qctrlopencontrols.dynamic_decoupling_sequences import DynamicDecouplingSequence
+from qctrlopencontrols.exceptions import ArgumentsValueError
+
+from qctrlopencontrols.qiskit import (


cirq should not import anything from qiskit. Could you pull these constants into global and put the method in a module where it would be more appropriate.

rajibchakravorty · 2019-05-30T05:03:45Z

@michaelhush

Troubling methods are removed - so no cross-module imports necessary anymore

# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method

# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method # This is the commit message #12: Public methods are bundled as __all__; changed ported over to notebooks; base object removed; repr method created # This is the commit message #13: additional error handling for new repr method # This is the commit message #14: repr method updated with class instance as input

Rajib Chakravorty added 12 commits May 22, 2019 11:15

working version of dds to cirq objects

e6b9912

cirq module added to qctrlopencontrols

f902915

Merge branch 'circuit-update' into cirq

3a2b22f

linted

d70f62f

tests for cirq circuits added

f78932a

docstring fixed/modified

224fff9

first draft of the notebook example added

08bc84b

modified test method; added cirq dependency in setup

4afc86b

notebook updated; test docstring modified

a1833c8

section for schedule added

c0e332f

Cirq docstring fixed

be172b0

a link from cirq_circuit docstring removed

5a851b7

rajibchakravorty requested a review from michaelhush May 23, 2019 00:44

charmasaur approved these changes May 23, 2019

View reviewed changes

Rajib Chakravorty and others added 16 commits May 23, 2019 11:29

typos corrected

c452889

Return docstring fixed

6ab61ed

Merge branch 'master' into cirq

38be35f

pre-post gate behaviour changed; tests modified and all pass

176b107

notebooks checked and updated

4b59627

notebooks checked and updated

22b0cdc

module docstring fixed

133b91b

merging upates related to pre-post gate behaviour

171dba9

cirq conversion method update with new changes of pre-post gate behav…

ac5e0e7

…iour

cirq example notebook updated with pre-post gate behaviour

b59cab6

linted

0f03a7d

cirq conversion method fixed according to updated behaviour wrt pre-p…

3c86754

…ost-gate

algorithm keyword docstring update

166e897

Update cirq notebook with minor changes in the text

31daa26

merged with master

9f0b945

Merge branch 'cirq' of github.com:qctrl/python-open-controls into cirq

af55d6e

Rajib Chakravorty added 2 commits May 24, 2019 17:11

notebooks renamed, titles updated

46a94ea

readme file updated with the new names of the notebook files and adde…

4b295d2

…d description for the cirq notebook

Rajib Chakravorty added 6 commits May 27, 2019 10:15

circuit, schedule separated; tests pass

e2cd204

module dosctring updated

228f256

cirq notebook updated with separate method for circuit and schedule; …

edd85f2

…algorithm keyword removed from qiskit example

both notebooks: some latex formatting fixed; qiskit notebook- gate_ti…

b3ffaed

…me in text updated to 0.4 to match the code

notebook updates merged

463f518

cirq files dosctring udpated to only contain either circuit or schedu…

25cda21

…le in respective files

Rajib Chakravorty and others added 2 commits May 29, 2019 20:47

Minor text correction in qiskit

ef95119

Minor link fix in notebook

f27def8

michaelhush reviewed May 30, 2019

View reviewed changes

Rajib Chakravorty added 9 commits May 30, 2019 14:01

get methods removed from qiskit; all methods are now self contained

9355810

minor text changes in cirq

8dc9294

linted

529507a

id gate insert logic fixed

7f9d2a2

merged changes after notebooks changed

048a160

cirq notebook run again after fixing the id gate insert logic

ab842fe

Merge branch 'cirq' of github.com:qctrl/python-open-controls into cirq

b56bc2a

cirq notebook synced with remote

6f04813

get_circuit_list finally removed from all files

f22f5ee

michaelhush approved these changes May 30, 2019

View reviewed changes

michaelhush merged commit 58a8ceb into master May 30, 2019

michaelhush deleted the cirq branch June 4, 2019 05:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding cirq support #5

Adding cirq support #5

Uh oh!

rajibchakravorty commented May 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charmasaur May 23, 2019

Uh oh!

rajibchakravorty May 23, 2019

Uh oh!

michaelhush commented May 24, 2019

Uh oh!

rajibchakravorty commented May 24, 2019

Uh oh!

michaelhush commented May 24, 2019

Uh oh!

rajibchakravorty commented May 27, 2019

Uh oh!

michaelhush May 30, 2019

Uh oh!

rajibchakravorty commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Adding cirq support #5

Adding cirq support #5

Uh oh!

Conversation

rajibchakravorty commented May 23, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

charmasaur May 23, 2019

Choose a reason for hiding this comment

Uh oh!

rajibchakravorty May 23, 2019

Choose a reason for hiding this comment

Uh oh!

michaelhush commented May 24, 2019

Uh oh!

rajibchakravorty commented May 24, 2019

Uh oh!

michaelhush commented May 24, 2019

Uh oh!

rajibchakravorty commented May 27, 2019

Uh oh!

michaelhush May 30, 2019

Choose a reason for hiding this comment

Uh oh!

rajibchakravorty commented May 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants