Circuit update #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhush
approved these changes
May 23, 2019
charmasaur
approved these changes
May 23, 2019
| quantum_circuit.barrier(quantum_registers[qubit]) #pylint: disable=no-member | ||
| if pre_post_gate_parameters is not None: | ||
| for qubit in target_qubits: | ||
| quantum_circuit.u3(pre_post_gate_parameters[0], #pylint: disable=no-member |
Contributor
There was a problem hiding this comment.
For my education, why's the disable=no-member tag necessary? Is there something in quantum_circuit we need to fix?
Contributor
Author
There was a problem hiding this comment.
@charmasaur - no it is a strange way how these are added to Qiskit library (the IBM One). This one might shed some light - https://quantumcomputing.stackexchange.com/questions/4962/how-to-fix-e1101instance-of-quantumcircuit-has-no-h-member-and-e1101in
Contributor
There was a problem hiding this comment.
Gotcha, thanks. Python is scary :S
rajibchakravorty
pushed a commit
that referenced
this pull request
Jun 12, 2019
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method
rajibchakravorty
pushed a commit
that referenced
this pull request
Jun 12, 2019
# This is the 1st commit message: starting pyquil support # This is the commit message #1: pyquil support added # This is the commit message #2: first version of pyquil notebook added # This is the commit message #3: pyquil dependency added to setup # This is the commit message #4: trying gcc install for pyquil # This is the commit message #5: replacing gcc install with build-essential # This is the commit message #6: forcing yes to install anything # This is the commit message #7: ignoring blocks in pyquil notebook for tests # This is the commit message #8: linted; unnecessary import removed from notebook # This is the commit message #9: removed all references of circuits and replaced those with programs; pyquil removed from method names # This is the commit message #10: notebook rerun after changes # This is the commit message #11: pyquil program conversion removes unnecessary method # This is the commit message #12: Public methods are bundled as __all__; changed ported over to notebooks; base object removed; repr method created # This is the commit message #13: additional error handling for new repr method # This is the commit message #14: repr method updated with class instance as input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour of
pre_post_gate_parametersupdated.Accepts a tuple of 3 numbers.
U3(...)op as pre-post gate in the circuit