Assume only 32u4 boards can run 'promicro' converters #23312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Mar 19, 2024
tzarc
approved these changes
Mar 20, 2024
|
Should this go to |
14 tasks
zvecr
force-pushed
the
converter_promicro_only_32u4
branch
from
55c6b8f
to
6596271
Compare
dlip
added a commit
to dlip/qmk_firmware
that referenced
this pull request
Mar 21, 2024
* upstream/master: (40 commits) [Keyboard] Add marshkeys flowerpad (qmk#23240) Add TechnicPad macropad (qmk#23238) Add handwired/Jotlily60 (qmk#23212) Add the EQUATOR keyboard (qmk#23237) Support for slice65 from PizzaKeyboards (qmk#23148) Add Swiss support (qmk#23272) Assume only 32u4 boards can run 'promicro' converters (qmk#23312) Add Macropad 6Pad (qmk#23099) Fix invalid use of stemcell converter (qmk#23317) Updates to PR Checklist (qmk#23318) [Keyboard] Add posey_split v4/v5 (qmk#23258) Added WT65-H3 (HIBI HIBIKI) (qmk#22886) Added WT65-G3 (HIBI HIBIKI) (qmk#22888) Modify wording in 'getting_started_introduction.md' (qmk#23232) Bump tj-actions/changed-files from 42 to 43 (qmk#23282) AMJKeyboard AMJ96 Layout Additions (qmk#23267) Fixup cipulot eeprom. (qmk#23280) Update feature_tri_layer.md - typo (qmk#23275) [Keyboard] add glyphkbd_v2 (qmk#23131) Add support new kb_elmo PCBs (qmk#23138) ...
j4ckofalltrades
pushed a commit
to j4ckofalltrades/qmk_firmware
that referenced
this pull request
Apr 10, 2024
* [Keyboard] Add 60XT (qmk#23210) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Ejectix (qmk#23204) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Add instructions for debugging ARM with VSCode+BMP. (qmk#11217) * [Keyboard] Add CMK11 (qmk#23239) * adding cmk11 * correcting default keymap * removing rules.mk * removing unnecessary comment * [Keyboard] Add sf2040 (qmk#23211) Co-authored-by: jack <0x6a73@protonmail.com> * Xiudi XD96 Layout Bugfixes and Touch-Up (qmk#23242) * Correct AliExpress Hardware Availability link in readme Previous URL linked to a Cospad listing. [chore] [docs] * Convert `info.json` to four-space indent [style] * Correct `LAYOUT_all` matrix data The right half of split Backspace is actually located at [5, 9], not [5, 3]. [bugfix] * Correct `LAYOUT_96_iso` matrix data Corrects the matrix positions of the ISO Hash/Tilde and ISO Enter keys to [3, 12] and [3, 13], respectively. [bugfix] * Add layout/matrix diagram [docs] * Refactor keymaps - remove "inline block" comments - grid-align keycodes - use four-space indent [style] * Orthograph: correct layout data (qmk#23213) * correct layout data Correct the key sizes and positions in the layout data. [chore] * remove layout offset Remove the dead space from the layout data. [chore] * Attempt to deal with GCC 13+ and rv32 arch extensions. (qmk#23086) * KBDfans KBD19x Layout Additions (qmk#23230) * Add layout/matrix diagram [docs] * Re-sort JSON `layouts` object Moves the `LAYOUT_all` object to be first in sequence. [refactor] * Add `LAYOUT_ansi_split_bs` [enhancement] * Add `LAYOUT_iso_split_bs` [enhancement] * Add `LAYOUT_ansi_wkl_split_bs` [enhancement] * Add `LAYOUT_ansi_wkl` [enhancement] * Add `LAYOUT_iso_wkl_split_bs` [enhancement] * Add `LAYOUT_iso_wkl` [enhancement] * Fixes for encoder abstraction. (qmk#23195) * kb-elmo AEK II USB: correct Configurator data (qmk#23252) Correct the QMK Configurator / `qmk info -m` data. [chore] * Flag LAYOUT macros still defined in .h files (qmk#23260) * Fix Magicforce MF17 RGB matrix (qmk#23263) * KBDfans KBD75 Layout Additions (qmk#23234) * Aero 75 Hotswap: correct layout data (qmk#23253) * Ares Layout Additions (qmk#23254) * [Keyboard] Add PetruziaMini (qmk#23201) * Uploading the PetruziaMini My first try on uploading somethings on github. Hoping it works, this is my handwired PetruziaMini. I don't know if it will be visible on qmk configurator now * 36 key hhbk inspired kb * Required changes done I compiled it locally and works * Last changes requested Added a imgur image (first time using, hoping i did it right) and summarized the description as requeste * Fixed imegur link * Ops, i've lost this. Here it comes Thanks for helping! I'll take notes for next time :) * Absolute paths for -kb argument should error consistently (qmk#23262) * Add KM113 keyboard (qmk#22669) * Add SIRIND Brick65 (qmk#23245) * Add support new kb_elmo PCBs (qmk#23138) Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] add glyphkbd_v2 (qmk#23131) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Update feature_tri_layer.md - typo (qmk#23275) * Fixup cipulot eeprom. (qmk#23280) * AMJKeyboard AMJ96 Layout Additions (qmk#23267) * Bump tj-actions/changed-files from 42 to 43 (qmk#23282) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 42 to 43. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v42...v43) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modify wording in 'getting_started_introduction.md' (qmk#23232) Co-authored-by: Joel Challis <git@zvecr.com> * Added WT65-G3 (HIBI HIBIKI) (qmk#22888) * Added WT65-H3 (HIBI HIBIKI) (qmk#22886) * [Keyboard] Add posey_split v4/v5 (qmk#23258) * Created posey_split keyboards and included default keymaps. * Update keyboards/pmk/posey_split/posey_split_v4/config.h Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/pmk/posey_split/posey_split_v4/config.h Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/pmk/posey_split/posey_split_v4/info.json Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/pmk/posey_split/posey_split_v4/info.json Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/posey_split_v4/info.json Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/posey_split_v4/readme.md Co-authored-by: jack <0x6a73@protonmail.com> * Various cleanup updates per QMK maintainers on PR qmk#23258 * removed config files from via keymaps * removed additional keyboard for PR. * changed folder structure per PR suggestion * Update keyboards/pmk/posey_split/v5/info.json Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v5/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v4/rules.mk Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v5/keymaps/VIA/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v5/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v4/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v4/keymaps/VIA/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v5/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v4/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v4/info.json Co-authored-by: Joel Challis <git@zvecr.com> * changed via folders to lowercase * cleaned up extra via files in wrong folder * Added better descriptions to keyboard projects and added hardware listing to v5 * Cleaned up keymap format * removed extra rules * Update keyboards/pmk/posey_split/v4/keymaps/via/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/pmk/posey_split/v5/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * removed "about" from readme on v4 * Removed title from readme --------- Co-authored-by: joliverMI <qmk@Desktop2023> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * Updates to PR Checklist (qmk#23318) * Fix invalid use of stemcell converter (qmk#23317) * Add Macropad 6Pad (qmk#23099) * Assume only 32u4 boards can run 'promicro' converters (qmk#23312) * Add Swiss support (qmk#23272) * Support for slice65 from PizzaKeyboards (qmk#23148) * Add the EQUATOR keyboard (qmk#23237) * Add handwired/Jotlily60 (qmk#23212) * Add TechnicPad macropad (qmk#23238) * [Keyboard] Add marshkeys flowerpad (qmk#23240) * handwired/jotlily60 via keymap (qmk#23325) * Add werk.technica werk.one keyboard (qmk#23130) * add wt one * update readme for One * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> * remove redundant file * reformatted info.json * Update keyboards/werk_technica/one/keymaps/via/rules.mk Co-authored-by: Danny <nooges@users.noreply.github.com> --------- Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Danny <nooges@users.noreply.github.com> * Add ES_GRV to latam language-specific keycodes (qmk#23333) * [Keyboard] Add T75 (qmk#23344) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * Bump tj-actions/changed-files from 43 to 44 (qmk#23369) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] mechwild/bb40 (qmk#22958) Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com> * [Keyboard] Bartlesplit (qmk#23114) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add haven60 (qmk#23062) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add Macropad 15Pad (qmk#23257) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add kb3x keyboard (qmk#23268) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Remove IGNORE_MOD_TAP_INTERRUPT from keymaps (qmk#23279) * [Keyboard] Add Minerva LX (qmk#23291) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Kalakos Bahrnob Layout Additions (qmk#23300) * [Keyboard] Add recore keyboard (qmk#23320) Co-authored-by: joliverMI <qmk@Desktop2023> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * tidy keymap of 60_ansi_arrow Community Layout (qmk#23301) * Clearer text about double tapping reset only working for boot after already having QMK running in board (qmk#23042) Co-authored-by: Drashna Jaelre <drashna@live.com> * Update serial_driver.md (qmk#23035) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add scorpio rev2 (qmk#22906) * [Keyboard] add neson design 810e keyboard (qmk#22883) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add miniDivide MAX (qmk#22804) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add new keyboard "Rookey" (qmk#22483) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] add arrowmechanics/wings (qmk#23328) Co-authored-by: Arrow Mechanics <filip@arrowmechanics.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add rot13labs hackboard (qmk#23218) Co-authored-by: c0ldbru <c0ldbrusec@gmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add skiller_skg50_s2 (qmk#23364) Co-authored-by: wb <wb@westberrytech.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * Fix 'qmk compile' mass_compile execution (qmk#23296) * [Keyboard] Add rose75 (qmk#22968) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Add MNK 60 EC (qmk#23167) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add MNK 65 EC (qmk#23168) * Fix in 60_iso_wkl_split_bs_rshift diagram (qmk#22654) * Add EC Type-K (qmk#23193) * merge/um80: remove pointless empty layers (qmk#23398) * handwired/technicpad: fix `keyboard` in keymaps (qmk#23408) * Fix pointing_device_set_cpi_on_side() (qmk#23391) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Fix malformed JSON in `layouts/default/ortho_5x10/info.json` (qmk#23414) * [Keyboard] Add Skelett60 (qmk#23409) Co-authored-by: yiancar <yiancar@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update hand_wire.md (qmk#23429) * Fix Layout_Arrow 3rd key in bottom row (qmk#23443) Co-authored-by: v <v@phux.dev> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: takashicompany <t@kashi.company> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: David Hoelscher <infinityis@users.noreply.github.com> Co-authored-by: strayfade <64668046+strayfade@users.noreply.github.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Allie <25503691+GalaxyAllie@users.noreply.github.com> Co-authored-by: LLLKST <160975620+LLLKST@users.noreply.github.com> Co-authored-by: wind <108604699+yelishang@users.noreply.github.com> Co-authored-by: era <73109780+eerraa@users.noreply.github.com> Co-authored-by: elmo <lorwel@mailbox.org> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: galile0 <134774462+galile0-designs@users.noreply.github.com> Co-authored-by: achim-t <achim-t@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: AlanLiu <125098342+AlanSub@users.noreply.github.com> Co-authored-by: Wilba <wilba@wilba.tech> Co-authored-by: joliverMI <36174681+joliverMI@users.noreply.github.com> Co-authored-by: joliverMI <qmk@Desktop2023> Co-authored-by: jack <0x6A73@pm.me> Co-authored-by: zlabkeeb <160311066+zlabkeeb@users.noreply.github.com> Co-authored-by: Bregoliii <34028962+Bregoliii@users.noreply.github.com> Co-authored-by: Chad Skeeters <chad.skeeters@gmail.com> Co-authored-by: Ramon Imbao <ramonimbao@gmail.com> Co-authored-by: jotix <69703151+jotix@users.noreply.github.com> Co-authored-by: NW <nwhirschfeld@users.noreply.github.com> Co-authored-by: Benjamin Božič <ethirallan@gmail.com> Co-authored-by: Moritz Plattner <moritz.plattner@gmx.net> Co-authored-by: Danny <nooges@users.noreply.github.com> Co-authored-by: JuanoD <3674588+JuanoD@users.noreply.github.com> Co-authored-by: Jacky <128167503+JackyJia73@users.noreply.github.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com> Co-authored-by: Kyrre Havik <Kyrremann@gmail.com> Co-authored-by: Freather <72902384+CMMS-Freather@users.noreply.github.com> Co-authored-by: Veriyans <162705394+veriyaniot@users.noreply.github.com> Co-authored-by: DOIO2022 <116554792+DOIO2022@users.noreply.github.com> Co-authored-by: Archetype <62484425+archetype-made@users.noreply.github.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Victor Camargo <victor.s.camargo@gmail.com> Co-authored-by: khchen2004 <148961563+khchen2004@users.noreply.github.com> Co-authored-by: yulei <yuleiz@gmail.com> Co-authored-by: Filip Strzałka <32881628+philvec@users.noreply.github.com> Co-authored-by: Arrow Mechanics <filip@arrowmechanics.com> Co-authored-by: c0ldbru <dennisp98@gmail.com> Co-authored-by: c0ldbru <c0ldbrusec@gmail.com> Co-authored-by: Joy Lee <joylee.lc@foxmail.com> Co-authored-by: wb <wb@westberrytech.com> Co-authored-by: SmollChungus <38044391+SmollChungus@users.noreply.github.com> Co-authored-by: Taro Hayashi <87086895+Taro-Hayashi@users.noreply.github.com> Co-authored-by: yiancar <yiangosyiangou@cytanet.com.cy> Co-authored-by: yiancar <yiancar@gmail.com> Co-authored-by: Felix Teutsch <63754496+FelixTeutsch@users.noreply.github.com> Co-authored-by: Draic <hiten@hotmail.de> Co-authored-by: v <v@phux.dev>
thebengeu
pushed a commit
to thebengeu/qmk_firmware
that referenced
this pull request
Apr 21, 2024
rottencandy
pushed a commit
to rottencandy/qmk_firmware
that referenced
this pull request
Apr 22, 2024
mzyt
pushed a commit
to mzyt/qmk_firmware
that referenced
this pull request
May 6, 2024
Coko7
pushed a commit
to Coko7/qmk_firmware
that referenced
this pull request
May 20, 2024
Mesabloo
pushed a commit
to Mesabloo/qmk_firmware
that referenced
this pull request
May 27, 2024
girtsf
pushed a commit
to girtsf/qmk_firmware
that referenced
this pull request
Jun 5, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuphy-src
pushed a commit
to nuphy-src/qmk_firmware
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users should not be trying to target "blackpill" based boards with the current available converters.
The following is logically incorrect...
However the error should be a bit more human readable than what is produced.
Long term, #20330 will solve the issue but that involves many keyboard upates.
Types of Changes
Issues Fixed or Closed by This PR
Checklist