Implement circuit_to_latex_using_qcircuit #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Find all places where docs/code says "ASCII" and replace it with "text" as appropriate - Split to_text_diagram_drawer out of circuit.to_text_diagram - Rename ascii_wire_symbols to text_diagram_wire_symbols - Rename ascii_exponent to text_diagram_exponent - Add optional qubit_count argument to text_diagram_wire_symbols - Add optional use_unicode_characters argument to text_diagram_wire_symbols - Remove unused XmonQubit try_parse_from_text method
Collaborator
|
Nice |
# Conflicts: # cirq/circuits/circuit.py
dabacon
approved these changes
Apr 16, 2018
| for moment in circuit.moments) | ||
|
|
||
|
|
||
| def circuit_to_latex_using_qcircuit( |
Collaborator
There was a problem hiding this comment.
I might just do circuit_to_latex. If we want to support something other than qcircuit we could pass some sort of type in to this to distiguish
Contributor
Author
There was a problem hiding this comment.
I also think that could be nice; but I'll wait until we have other supported formats before amalgamating.
Collaborator
|
it's just a really long method name
…On Mon, Apr 16, 2018 at 3:02 PM, Craig Gidney ***@***.***> wrote:
Merged #295 <#295>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFXproJM9-QrHEZjHSYOqL9wfLa1oNgks5tpRUCgaJpZM4TPRYj>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #293
Example rendered output: