Observable Measurement - 2 - Grouping #3372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
force-pushed
the
2020-10-operator-estimation-2-grouping
branch
from
db77b75 to
ec9d941
Compare
This was referenced Sep 30, 2020
mpharrigan
force-pushed
the
2020-10-operator-estimation-2-grouping
branch
from
ec9d941 to
500cb25
Compare
mpharrigan
force-pushed
the
2020-10-operator-estimation-2-grouping
branch
from
500cb25 to
581cc73
Compare
mpharrigan
force-pushed
the
2020-10-operator-estimation-2-grouping
branch
from
581cc73 to
d89bc46
Compare
balopat
suggested changes
Oct 20, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
This looks good, I added a bunch of nits
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
…ping' into 2020-10-operator-estimation-2-grouping
Collaborator
Author
|
Your suggested change to the |
Collaborator
Author
|
Also the formatter insists on a formatting that breaks pylint (line too long) |
balopat
approved these changes
Oct 21, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
Awesome, thanks for the quick fixes!
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
CirqBot
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #2781
Follows #3371