Skip to content

Add mock to env_config_test #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CirqBot merged 1 commit into from
Oct 6, 2020
Merged

Add mock to env_config_test #3398

CirqBot merged 1 commit into from
Oct 6, 2020

Conversation

@dstrain115
Copy link
Collaborator

@dstrain115 dstrain115 commented Oct 6, 2020

  • Add mock to env_config_test deprecation test.
  • Without the mock, the environment calls the engine, which
    fails in certain environments.

@dstrain115
Add mock to env_config_test
d422e21 
- Add mock to env_config_test deprecation test.
- Without the mock, the environment calls the engine, which
fails in certain environments.
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Oct 6, 2020
@dstrain115 dstrain115 requested a review from balopat October 6, 2020 16:01
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 6, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 6, 2020
@CirqBot CirqBot merged commit a294223 into quantumlib:master Oct 6, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@balopat balopat balopat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Makes googlebot stop complaining.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dstrain115 @balopat @googlebot @CirqBot