[3 qubit decomposition] Extract diagonal #3472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
requested changes
Nov 25, 2020
Collaborator
viathor
left a comment
viathor
left a comment
There was a problem hiding this comment.
Sorry for the delay in review! It's very cool to have this in cirq! Thank you! See comments below.
viathor
approved these changes
Nov 26, 2020
Collaborator
viathor
left a comment
viathor
left a comment
There was a problem hiding this comment.
This is very cool! Thank you!
cirq/linalg/decompositions.py
Outdated
| import scipy | ||
| import matplotlib.pyplot as plt | ||
| import scipy | ||
| from scipy.linalg.special_matrices import block_diag |
Collaborator
There was a problem hiding this comment.
remove line to placate linter
cirq/linalg/decompositions.py
Outdated
| return u @ YY @ u.T @ YY | ||
|
|
||
|
|
||
| def extract_right_diag(u: np.ndarray, atol=1e-15) -> np.ndarray: |
Collaborator
There was a problem hiding this comment.
remove unused atol from signature and Args section of docstring below
Contributor
Author
|
Thank you for the thorough and insightful review @viathor!! |
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cirq.two_qubit_matrix_to_diagonal_and_operationsthat extracts a diagonal if it can from a 3CNOT unitary to a diagonal and a 2 CNOT unitary.Another part of #2873.