JSON Serialization for CalibrationResult and CalibrationLayer #3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Serializes CalibrationResult dataclass - Uses underlying Calibration serialization and datetime utc timestamp.
dstrain115
requested review from
a team,
cduck,
vtomole and
wcourtney
as code owners
dstrain115
changed the title
balopat
previously requested changes
Dec 1, 2020
Contributor
balopat
left a comment
balopat
left a comment
There was a problem hiding this comment.
lgtm but the json test data is in the wrong place
| @@ -0,0 +1,79 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
these should live under cirq.google.json_test_data
balopat
dismissed
their stale review
I don't know what I smoked, the modular json PR is not yet merged. Sorry :)
balopat
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These objects are the client objects for calibration calls in engine.