Wrap input json_dict entries in np.array to avoid wrong type deduction #3679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
approved these changes
Jan 15, 2021
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
mpharrigan
reviewed
Jan 15, 2021
| copy.gamma = gamma.copy() | ||
| copy.v = v.copy() | ||
| copy.s = s.copy() | ||
| copy.G = np.array(G.copy()) |
Collaborator
There was a problem hiding this comment.
You can remove the copy. This can be just np.array(G) which copies by default. [otherwise, you should be using np.asarray, which doesn't copy]
Collaborator
Author
There was a problem hiding this comment.
Thanks, I'll send out a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not doing this caused an issue where the JSON was parsed without issue but when using the object, certain methods would break since they expected an np.array and got a list.
Example: #3645 (comment)
Dynamic typing strikes again!