Skip to content

Conversation

@balopat
Copy link
Contributor

@balopat balopat commented May 11, 2021

Updating notebook pip installs after v0.11 release.

  • Changed all pip install cirq --pre to pip install cirq.
  • Removed pre-release notices.
  • Removed pre-release skip list from isolated_notebook_tests.py.
  • cirq[contrib] is now cirq-core[contrib] so I updated notebooks and docs
  • educators/chemistry.ipynb testing is skipped currently until we upgrade OpenFermion to the new Cirq (it is still using cirq.TrialResult, that was removed in v0.11)

@balopat balopat requested review from a team, cduck, vtomole and wcourtney as code owners May 11, 2021 21:44
@balopat balopat requested a review from tanujkhattar May 11, 2021 21:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label May 11, 2021
@mpharrigan
Copy link
Collaborator

When we push the docs, do we have a notion of "stable release" vs "latest dev version" (for the docs)? It would be nice if the first thing users navigating the docs land on is the non --pre notebooks [that may not be up-to-date with HEAD]

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 12, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 12, 2021
@CirqBot CirqBot merged commit f7c1156 into quantumlib:master May 12, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 12, 2021
@balopat
Copy link
Contributor Author

balopat commented May 12, 2021

When we push the docs, do we have a notion of "stable release" vs "latest dev version" (for the docs)? It would be nice if the first thing users navigating the docs land on is the non --pre notebooks [that may not be up-to-date with HEAD]

There is no such notion per se, so the best I could come up with was to rely on manually marking these notebooks (hence the pre-release notice in the notebooks guide).

Additional to the notice, we could add the "experimental" tag to the menupoints and mark "dev version" notebooks as such. This would put a little beaker icon next to the menupoint like here:

image

@mpharrigan
Copy link
Collaborator

mpharrigan commented May 13, 2021 via email

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Updating notebook `pip install`s after v0.11 release. 
- Changed all `pip install cirq --pre` to `pip install cirq`. 
- Removed pre-release notices. 
- Removed pre-release skip list from isolated_notebook_tests.py. 
- cirq[contrib] is now cirq-core[contrib] so I updated notebooks and docs
- educators/chemistry.ipynb testing is skipped currently until we upgrade OpenFermion to the new Cirq (it is still using `cirq.TrialResult`, that was removed in v0.11)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Updating notebook `pip install`s after v0.11 release. 
- Changed all `pip install cirq --pre` to `pip install cirq`. 
- Removed pre-release notices. 
- Removed pre-release skip list from isolated_notebook_tests.py. 
- cirq[contrib] is now cirq-core[contrib] so I updated notebooks and docs
- educators/chemistry.ipynb testing is skipped currently until we upgrade OpenFermion to the new Cirq (it is still using `cirq.TrialResult`, that was removed in v0.11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Makes googlebot stop complaining.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants