Add testing helper for consistent channel/mixture #5247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MichaelBroughton
left a comment
MichaelBroughton
left a comment
There was a problem hiding this comment.
Could we also add similar for mixture ?
Collaborator
|
Related: #4365 |
Comment on lines
20
to
26
| def assert_consistent_channel(gate: Any, rtol: float = 1e-5, atol: float = 1e-8): | ||
| assert cirq.has_kraus(gate), f"Given gate {gate!r} does not return True cirq.has_kraus." | ||
| kraus_ops = cirq.kraus(gate) | ||
| assert cirq.is_cptp(kraus_ops=kraus_ops, rtol=rtol, atol=atol), ( | ||
| f"Kraus operators for {gate!r} did not sum to identity up to expected tolerances. " | ||
| f"Summed to {sum(m.T.conj() @ m for m in kraus_ops)}" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Please also add tests for has_mixture and mixture.
dabacon
changed the title
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Adds a helper that tests that channel kraus operator is cptp (\sum_i A_i^\dagger A_i = I) and that has_kraus is true. Uses this on channels. Adds a helper for testing that mixture's probabilities sum to 1. Uses this on mixtures. Fixes quantumlib#2271
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Adds a helper that tests that channel kraus operator is cptp (\sum_i A_i^\dagger A_i = I) and that has_kraus is true. Uses this on channels. Adds a helper for testing that mixture's probabilities sum to 1. Uses this on mixtures. Fixes quantumlib#2271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper that tests that channel kraus operator is cptp (\sum_i A_i^\dagger A_i = I) and that has_kraus is true. Uses this on channels.
Adds a helper for testing that mixture's probabilities sum to 1. Uses this on mixtures.
Fixes #2271