Adjust protocols document #5297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Apr 27, 2022
dstrain115
commented
- Move import up to top.
- Fix formula formatting.
- Add missing protocols.
- Move import up to top. - Fix formula formatting. - Add missing protocols.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dabacon
reviewed
Apr 27, 2022
| " </td>\n", | ||
| "</table>" | ||
| ] | ||
| }, |
Collaborator
There was a problem hiding this comment.
nit: "operator" seems like the wrong word. I would just say "object" since it applies to both operations and gates. But maybe "operation or gate"
Reply via ReviewNB
dabacon
approved these changes
Apr 27, 2022
Collaborator
dabacon
left a comment
dabacon
left a comment
There was a problem hiding this comment.
One minor nit and also it looks like all the outputs were not cleared.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Adjust protocols document - Move import up to top. - Fix formula formatting. - Add missing protocols. - Clear outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.