Update Pasqal Tutorial Documentation #5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Pasqal documentation to use device validation rather than devices attached to circuits. - Clean up code so that repeated executions do not fail noise model or validation. - Clear output. - Add a few code comments.
dstrain115
requested review from
a team,
HGSilveri,
cduck and
vtomole
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HGSilveri
reviewed
May 2, 2022
| "source": [ | ||
| "try:\n", | ||
| " import cirq\n", | ||
| "except ImportError:\n", |
Collaborator
There was a problem hiding this comment.
Line #2. too_far_away_circuit = cirq.Circuit()
What's the need for this circuit? It seems it is never used
Reply via ReviewNB
Collaborator
Author
There was a problem hiding this comment.
Removed. Was a remnant of when the below operation was a circuit.
HGSilveri
approved these changes
May 2, 2022
Collaborator
HGSilveri
left a comment
HGSilveri
left a comment
There was a problem hiding this comment.
Thanks for the update, it LGTM overall!
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Update Pasqal Tutorial Documentation - Update Pasqal documentation to use device validation rather than devices attached to circuits. - Clean up code so that repeated executions do not fail noise model or validation. - Clear output. - Add a few code comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than devices attached to circuits.
model or validation.