Fix Qubit Placement docs #5321
Fix Qubit Placement docs #5321
Conversation
- Install cirq pre-release to get new qubit placement stuff like hard coded qubit placement/ - This should hopefully fix docs errors.
dstrain115
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
If I open: and run from start to finish, the notebook fails. Can we diagnose why and fix it as a part of this PR ? |
|
It would also be nice if instead of ignoring all /google/ notebooks from testing, we only ignored notebooks that actually depend upon cloud auth. Also, the "view on Quantum AI" link seems broken: https://quantumai.google/cirq/google/qubit-placement gives 404 error. |
Done. |
Sure, but that is out of scope for this PR. I will open a new PR for that in a bit. The view on quantum AI is broken since the notebook does not run, which is what this PR is fixing. |
| @@ -1,10 +1,9 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
Line #5. !pip install --pre --quiet cirq
Let's add the note on top that this notebook depends on unreleased features and add the notebook to https://github.com/quantumlib/Cirq/blob/4ba978807b163c6d1ee51c1dea994c731d6400c5/dev_tools/notebooks/isolated_notebook_test.py#L43 so that we remember to remove the --pre after next release.
Reply via ReviewNB
There was a problem hiding this comment.
Good idea. Done.
* Fix Qubit Placement docs - Install cirq pre-release to get new qubit placement stuff like hard coded qubit placement/ - This should hopefully fix docs errors. * Fix hard coded qubit placement issues. * Add pre release justification. * Reorder arguments so that test finds --pre * Add note about unreleased features. * Fix extra quote.
4 participants
stuff like hard coded qubit placement/