Skip to content

Update unitary for IonQ MS Gate #5335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 11, 2022
Merged

Update unitary for IonQ MS Gate #5335

merged 16 commits into from
May 11, 2022

Conversation

@Cynocracy
Copy link
Contributor

@Cynocracy Cynocracy commented May 6, 2022

No description provided.

@CirqBot CirqBot added the size: S 10< lines changed <50 label May 6, 2022
@Cynocracy
Copy link
Contributor Author

Cynocracy commented May 6, 2022

Not sure about the exact format here, other SDKs I was updating using math format, but I get pylint warnings, so I've escaped some backslashes. Hoping this all renders fine!

@Cynocracy
Copy link
Contributor Author

Cynocracy commented May 6, 2022

After much python string wrangling, I think this is ready 🙏

dabacon
dabacon approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We are systematically upgrading gates to use LaTeX as it displays better, but for now this is a good fix.

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 9, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 9, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented May 9, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Misc check', 'Notebook formatting', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Type check', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels May 9, 2022
@Cynocracy
Copy link
Contributor Author

Cynocracy commented May 9, 2022

Ah, sorry, started fixing a unit error in the unitary and didn't realize this had been tagged

@ColemanCollins ColemanCollins merged commit f318b83 into quantumlib:master May 11, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@Cynocracy @CirqBot
@ColemanCollins @rht
Update unitary for IonQ MS Gate (quantumlib#5335)
c65c535 
* Update unitary for IonQ MS Gate

* Whoops, diff format

* minor format

* also minor fixup

* Math mode please

* Escape \

* Use r strings

* Units and unitaries

* fixup

* phi1,2 -> phi0,1 for consistency with other SDKs

* np\.

Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Co-authored-by: Coleman Collins <coleman@colemancollins.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@ColemanCollins ColemanCollins Awaiting requested review from ColemanCollins

@nakardo nakardo Awaiting requested review from nakardo

@gmauricio gmauricio Awaiting requested review from gmauricio

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees

No one assigned

Labels

size: S 10< lines changed <50

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Cynocracy @CirqBot @dabacon @ColemanCollins @tanujkhattar