Median device calibrations #5338
Conversation
95-martin-orion
requested review from
a team,
cduck,
verult,
vtomole and
wcourtney
as code owners
dstrain115
left a comment
dstrain115
left a comment
There was a problem hiding this comment.
Just some nit picks on this.
| Real calibration data from Google's 'rainbow' and 'weber' devices has been | ||
| saved in Cirq. The calibrations selected are roughly representative of the | ||
| median performance for that chip. |
There was a problem hiding this comment.
Worth commenting (or linking to the docs) which metrics are included in this data?
There was a problem hiding this comment.
Done, although I don't think the docs cover all of the metrics anymore.
There was a problem hiding this comment.
Maybe we should augment the docs then in a later PR.
| Real calibration data from Google's 'rainbow' and 'weber' devices has been | ||
| saved in Cirq. The calibrations selected are roughly representative of the | ||
| median performance for that chip. |
There was a problem hiding this comment.
Maybe we should augment the docs then in a later PR.
| median performance for that chip. | ||
| A description of the stored metrics can be found here: | ||
| https://quantumai.google/cirq/google/calibration |
There was a problem hiding this comment.
Can you doublecheck to make sure this is correct formatting?
See Dave's recent PR #5220
Not sure if this needs an {:.external} if it is on quantumai.
There was a problem hiding this comment.
Switched to match formatting. It seems like skipping the {:.external} is in the spirit of the TFdocs rule, though I don't know if the warnings Dave mentioned will see it that way :/
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Adds methods for loading median calibration data for one of two devices. This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.
3 participants
Adds methods for loading median calibration data for one of two devices.
This PR also includes the median data packaged in JSON format, as well as a modfied date format (YYYY-MM-DD) on device spec files to avoid month/day confusion.