Add json serialization to diagonal gates #5356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Summoning @mpharrigan the json master. |
mpharrigan
reviewed
May 16, 2022
| @@ -0,0 +1 @@ | |||
| cirq.DiagonalGate(diag_angles_radians=[0.0, 1.0, -1.0, 0.0]) No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
it's strange that the repr turns the values to a list instead of keeping it a tuple, but I see that's how it's always been and isn't from this PR.
mpharrigan
approved these changes
May 16, 2022
Collaborator
mpharrigan
left a comment
mpharrigan
left a comment
There was a problem hiding this comment.
the not_yet_serializable list grows ever smaller.
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
Collaborator
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Misc check', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a small change in type annotations to
cirq.ThreeQubitDiagonalGate. The argument type is more general so this should be backwards compatible. This change aligns with the other diagonal gates for consistency.Part of #5353