Skip to content

Conversation

@dabacon
Copy link
Collaborator

@dabacon dabacon commented May 20, 2022

See #5383

Dill appears to have a problem when used from pylint due to a very recent package push. Bumping this back, "fixes" the issue.

@CirqBot CirqBot added the Size: XS <10 lines changed label May 20, 2022
@dabacon dabacon changed the title Testing Lint Fix lint failure May 20, 2022
@dabacon dabacon marked this pull request as ready for review May 20, 2022 00:21
@dabacon dabacon requested review from a team, cduck and vtomole as code owners May 20, 2022 00:21
@dabacon dabacon requested a review from 95-martin-orion May 20, 2022 00:21
@dabacon
Copy link
Collaborator Author

dabacon commented May 20, 2022

Now a notebook test is failing wtf

@dabacon
Copy link
Collaborator Author

dabacon commented May 20, 2022

New bug looks like #5355

No clue why this is showing up now.

@dabacon dabacon requested review from verult and wcourtney as code owners May 20, 2022 01:02
@dabacon dabacon merged commit 2cf54f0 into quantumlib:master May 20, 2022
@dabacon
Copy link
Collaborator Author

dabacon commented May 20, 2022

There was a notebook that used cirq --pre but was not in the excluded list. I've added it there which fixes things. Need to investigate why that got through CI

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants