Skip to content

Ignore operations on more than 10 qubits in drop_negligible_operations transformer #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanujkhattar merged 3 commits into from
May 23, 2022
Merged

Ignore operations on more than 10 qubits in drop_negligible_operations transformer #5386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2ed9c3
Ignore operations on more than 10 qubits in drop_negligible_operation…
tanujkhattar May 21, 2022
8890251
Merge branch 'master' into fix_drop_negligible
CirqBot May 23, 2022
0c43e98
Assert same circuits
tanujkhattar May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cirq-core/cirq/transformers/drop_negligible_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ def drop_negligible_operations(

def map_func(op: 'cirq.Operation', _: int) -> 'cirq.OP_TREE':
return (
op if protocols.is_measurement(op) or protocols.trace_distance_bound(op) > atol else []
op
if protocols.num_qubits(op) > 10
or protocols.is_measurement(op)
or protocols.trace_distance_bound(op) > atol
else []
)

return transformer_primitives.map_operations(
Expand Down
13 changes: 13 additions & 0 deletions cirq-core/cirq/transformers/drop_negligible_operations_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,16 @@ def test_recursively_runs_inside_circuit_ops_deep():
cirq.testing.assert_same_circuits(
cirq.drop_negligible_operations(c_orig, context=context, atol=0.001), c_expected
)


def test_ignores_large_ops():
qnum = 20
qubits = cirq.LineQubit.range(qnum)
subcircuit = cirq.FrozenCircuit(cirq.X.on_each(*qubits))
circuit = cirq.Circuit(
cirq.CircuitOperation(subcircuit).repeat(10), cirq.measure(*qubits, key='out')
)
cirq.testing.assert_same_circuits(
circuit,
cirq.drop_negligible_operations(circuit, context=cirq.TransformerContext(deep=True)),
)