Add CircuitOperation blurb #5399
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| "id": "cDAVDT7bAwDO" | ||
| }, | ||
| "source": [ | ||
| "Especially useful is dropping the last moment (which are often just measurements): `circuit[:-1]`, or reversing a circuit: `circuit[::-1]`.\n" |
There was a problem hiding this comment.
Does CircuitOperation add a link to the reference page or we need to write cirq.CircuitOperation ? Please change, here and elsewhere, if it's the latter.
Reply via ReviewNB
There was a problem hiding this comment.
Done for the first appearance of CircuitOperation - I think this is our strategy in general, similar to Wikipedia-style linking.
| "id": "cDAVDT7bAwDO" | ||
| }, | ||
| "source": [ | ||
| "Especially useful is dropping the last moment (which are often just measurements): `circuit[:-1]`, or reversing a circuit: `circuit[::-1]`.\n" |
There was a problem hiding this comment.
I think we should also add a section to explain circuit_op.repeat_until and circuit_op.mapped_circuit.
Reply via ReviewNB
There was a problem hiding this comment.
repeat_until requires measurement and classical control, neither of which are discussed in this high-level doc. Happy to add mapped_circuit, though.
| "id": "cDAVDT7bAwDO" | ||
| }, | ||
| "source": [ | ||
| "Especially useful is dropping the last moment (which are often just measurements): `circuit[:-1]`, or reversing a circuit: `circuit[::-1]`.\n" |
There was a problem hiding this comment.
qubits = [cirq.GridQubit(x, y) for x in range(3) for y in range(3)] can be qubits=cirq.GridQubit.square(3)
| "subcircuit_op = cirq.CircuitOperation(cirq.FrozenCircuit(CZ(q0, q1)))\n", | ||
| "repeated_subcircuit_op = subcircuit_op.repeat(2)\n", | ||
| "moved_subcircuit_op = subcircuit_op.with_qubit_mapping({q0: q2})\n", | ||
| "circuit = cirq.Circuit(\n", |
There was a problem hiding this comment.
It might be useful to have some line comments to further explain this example.
augustehirth
left a comment
augustehirth
left a comment
There was a problem hiding this comment.
Pending others' comments, looks great to me.
|
Pinging @dstrain115 or @tanujkhattar for final approval. |
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Documents `CircuitOperation` usage on the "Circuits" page.
5 participants
Documents
CircuitOperationusage on the "Circuits" page.