-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Document classical control #5403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
CC @augustehirth and @daxfohl. For @daxfohl: are there any other weird behaviors / use cases you think are worth highlighting here? |
|
Do you want to highlight deferred measurements conversions? There are examples in the tests. https://github.com/quantumlib/Cirq/pull/4849/files. This is allows running equivalent circuits on a real device (at the cost of requiring ancilla qubits). Should also highlight QASM support once it's fixed. (Victory marked it as post 1.0 but it should be a straightforward fix if anyone has time before then #5388). |
Done, plus a brief general mention of how transformers interact with classical control. There's something to be said for the fact that transformers are a separate complex topic, but since this will be filed under "Advanced" I think it's reasonable to assume that readers are familiar with (or at least willing to read) the transformers documentation.
Copied the example from |
|
@95-martin-orion What else needs to be done for this? After your updates it looks great to me. |
Just need approval from maintainers. |
This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.
This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.
This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.