Skip to content

Conversation

@95-martin-orion
Copy link
Collaborator

This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.

@95-martin-orion 95-martin-orion requested review from a team, cduck and vtomole as code owners May 25, 2022 22:55
@95-martin-orion 95-martin-orion requested a review from maffoo May 25, 2022 22:55
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label May 25, 2022
@95-martin-orion
Copy link
Collaborator Author

CC @augustehirth and @daxfohl.

For @daxfohl: are there any other weird behaviors / use cases you think are worth highlighting here?

@daxfohl
Copy link
Collaborator

daxfohl commented May 25, 2022

Do you want to highlight deferred measurements conversions? There are examples in the tests. https://github.com/quantumlib/Cirq/pull/4849/files. This is allows running equivalent circuits on a real device (at the cost of requiring ancilla qubits).

Should also highlight QASM support once it's fixed. (Victory marked it as post 1.0 but it should be a straightforward fix if anyone has time before then #5388).

@95-martin-orion
Copy link
Collaborator Author

Do you want to highlight deferred measurements conversions?

Done, plus a brief general mention of how transformers interact with classical control. There's something to be said for the fact that transformers are a separate complex topic, but since this will be filed under "Advanced" I think it's reasonable to assume that readers are familiar with (or at least willing to read) the transformers documentation.

Also maybe the teleportation circuit would be good to reference

Copied the example from examples/ into the Basic Conditions section.

@augustehirth
Copy link
Collaborator

@95-martin-orion What else needs to be done for this? After your updates it looks great to me.

@95-martin-orion
Copy link
Collaborator Author

@95-martin-orion What else needs to be done for this? After your updates it looks great to me.

Just need approval from maintainers.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 6, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 6, 2022
@CirqBot CirqBot merged commit 847e7fc into quantumlib:master Jun 6, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 6, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
This PR adds a docs page for classical control detailing some basic use cases and edge behavior to consider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: M 50< lines changed <250

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants