Skip to content

Simplify cd to the executing script directory #5412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2022
Merged

Simplify cd to the executing script directory #5412

merged 2 commits into from
Jun 1, 2022

Conversation

@pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented May 27, 2022

Nitpicking - let us drop redundant cd "$(pwd)"

@pavoljuhas pavoljuhas requested review from a team, cduck and vtomole as code owners May 27, 2022 01:56
@pavoljuhas pavoljuhas requested a review from maffoo May 27, 2022 01:56
@CirqBot CirqBot added the size: S 10< lines changed <50 label May 27, 2022
@dabacon
Copy link
Collaborator

dabacon commented May 27, 2022 •
edited
Loading

Any idea why this was there? My bash foo is poor.

@pavoljuhas
Copy link
Collaborator Author

pavoljuhas commented May 27, 2022

Any idea why this was there? My bash foo is poor.

Looks like it was inspired by https://stackoverflow.com/q/39340169 :-)

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

That snippet needs pwd to output the absolute path for the DIR variable.
We don't really need the absolute path, we want to change to the script's directory,
which is already done with cd "$(dirname ...)")

dabacon
dabacon approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 1, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 1, 2022
@CirqBot CirqBot merged commit a2b9d9d into quantumlib:master Jun 1, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 1, 2022
@pavoljuhas pavoljuhas deleted the drop-noop-cd-pwd branch June 2, 2022 17:11
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Simplify cd to the executing script directory (quantumlib#5412)
728e051 
Nitpicking - let us drop redundant `cd "$(pwd)"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dabacon dabacon dabacon approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees

@dabacon dabacon

Labels

size: S 10< lines changed <50

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pavoljuhas @dabacon @CirqBot